thegeneralist01/archivr
1
Fork 0
mirror of https://github.com/thegeneralist01/archivr synced 2026-10-09 12:55:00 +02:00
Code Issues Activity

fix: guard detailMatchesSelection against null detail/selectedEntry

Browse source 
When both detail and selectedEntry are null (initial render or mid-navigation
while a detail fetch is in flight), detail?.summary?.entry_uid and
selectedEntry?.entry_uid both evaluate to undefined, making the equality
true and causing a crash on detail.latest_summary.

Add selectedEntry?.entry_uid != null guard so the condition short-circuits
false whenever there is no real selection.
This commit is contained in:
archivr-qa 2026-08-28 20:25:41 +02:00
parent 79ac44834e
commit 9b2ecb8d7b
No known key found for this signature in database
3 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
frontend/src/components/ContextRail.jsx
View file

@ -143,7 +143,8 @@ export default function ContextRail({ archiveId, selectedEntry, selectedUids, se
summaryPollAbortRef.current = null
summaryGenerateAbortRef.current?.abort()
summaryGenerateAbortRef.current = null
const detailMatchesSelection = detail?.summary?.entry_uid === selectedEntry?.entry_uid
const detailMatchesSelection = selectedEntry?.entry_uid != null &&
detail?.summary?.entry_uid === selectedEntry?.entry_uid
setSummary(detailMatchesSelection ? detail.latest_summary ?? null : null)
setSummaryAttempt(detailMatchesSelection ? detail.summary_attempt ?? null : null)
setSummaryError('')