thegeneralist01/archivr
1
Fork 0
mirror of https://github.com/thegeneralist01/archivr synced 2026-10-09 21:03:17 +02:00
Code Issues Activity

fix: allow escaped full-size text captures

Browse source
This commit is contained in:
archivr-qa 2026-08-24 17:13:32 +02:00
parent 56d60f2808
commit cbbbd9e144
No known key found for this signature in database
1 changed files with 29 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

31
crates/archivr-server/src/routes.rs
View file

@ -50,8 +50,9 @@ use rusqlite::OptionalExtension;
const LOGIN_WINDOW: Duration = Duration::from_secs(15 * 60);
const LOGIN_MAX_ATTEMPTS: usize = 5;
const MAX_TEXT_CAPTURE_BODY_BYTES: usize = 2 * 1024 * 1024;
// The request includes a small JSON envelope in addition to the text body.
const MAX_TEXT_CAPTURE_REQUEST_BYTES: usize = MAX_TEXT_CAPTURE_BODY_BYTES + 64 * 1024;
// JSON can expand each body byte into a six-byte `\\u00XX` escape sequence,
// plus a small request envelope.
const MAX_TEXT_CAPTURE_REQUEST_BYTES: usize = MAX_TEXT_CAPTURE_BODY_BYTES * 6 + 64 * 1024;
// Short-lived token granting unauthenticated access to one specific artifact.
// Used so Cast / AirPlay devices (which carry no session cookie) can fetch media.
@ -4401,6 +4402,32 @@ mod tests {
assert_eq!(response.status(), StatusCode::ACCEPTED);
}
#[tokio::test]
async fn text_capture_accepts_a_two_mebibyte_body_with_json_escaped_controls() {
let dir = tempfile::tempdir().unwrap();
let (registry, _, auth_path) = make_test_registry(&dir);
let session_cookie = make_test_session(&auth_path);
let body = "\0".repeat(2 * 1024 * 1024);
let response = app(registry, auth_path)
.oneshot(
Request::builder()
.method("POST")
.uri("/api/archives/test/captures/text")
.header("content-type", "application/json")
.header("cookie", &session_cookie)
.body(json_body(&serde_json::json!({
"title": "Escaped control note",
"body": body,
"mime": "text/plain"
})))
.unwrap(),
)
.await
.unwrap();
assert_eq!(response.status(), StatusCode::ACCEPTED);
}
#[tokio::test]
async fn text_capture_rejects_a_body_over_two_mebibytes_with_validation_error() {
let dir = tempfile::tempdir().unwrap();